-
Notifications
You must be signed in to change notification settings - Fork 421
feat(data-classes): support for code pipeline job event #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-classes): support for code pipeline job event #416
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #416 +/- ##
=========================================
Coverage 99.89% 99.90%
=========================================
Files 101 102 +1
Lines 3996 4117 +121
Branches 199 204 +5
=========================================
+ Hits 3992 4113 +121
Misses 1 1
Partials 3 3
Continue to review full report at Codecov.
|
Lemme know when it's ready. I think you mentioned about adding an UTF decode before finalizing the implementation |
Changes: - Add more helper functions to code_pipeline_job_event
@heitorlessa i added some docs for this. So i think it is ready :) |
@jplock if you want to have a look too |
@heitorlessa anything missing here? |
Hey! I’ll look it over tomorrow ;-)
I’d like to make a minor release tomorrow to get this out to everyone -
it’d be nice to have some UX examples in the PR description to make it
easier to release and make this stand out
…On Thu, 13 May 2021 at 18:46, Michael Brewer ***@***.***> wrote:
@heitorlessa <https://github.com/heitorlessa> anything missing here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#416 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPQBEBAEN2TUJRV23FCX3TNP67XANCNFSM44B4Z45A>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on this!
Note to self - Find a better name for this utility in 2.0, something like
event source
Issue #, if available:
https://github.com/awslabs/aws-lambda-powertools-python/issues/414
Description of changes:
Add support for CodePipeline Job event data class
Code example based on the docs:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.